Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvass instructions #2428

Merged
merged 15 commits into from
Dec 20, 2024
Merged

Canvass instructions #2428

merged 15 commits into from
Dec 20, 2024

Conversation

rebecarubio
Copy link
Contributor

@rebecarubio rebecarubio commented Dec 17, 2024

Description

This PR adds the ability to include instructions for canvass assignments. Organizers can now provide detailed instructions through the newly introduced "Instructions" tab. Canvassers can view these instructions either by clicking on an assignment or accessing them via the CanvasserSidebar component.

Screenshots

Changes

  • Adds new property instructions to canvassAssignment type and model
  • Adds new tab called instructions
  • Adds a new page called CanvassAssignmentInstructionsPage with a text editor in the Organizer UI
  • Adds new hook useCanvassInstructions
  • Adds instructions in CanvasserSideBar component
  • Adds new component MyCanvassAssignmentPage with stats and instructions
  • Change redirect to MyCanvassAssignmentPage on /map

Notes to reviewer

None

Related issues

None

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I have tried the preview build and I have reviewed the code. I found a tiny little piece of dead code but it's not worth making changes over. This will need to be revisited for design polish anyway. Let's merge! 💯

> = ({ orgId, canvassAssId }) => {
const { showConfirmDialog } = useContext(ZUIConfirmDialogContext);

// const messages = useMessages(messageIds);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code should be removed.

@richardolsson richardolsson merged commit 957c0fb into main Dec 20, 2024
6 checks passed
@richardolsson richardolsson deleted the undocumented/canvass-intructions branch December 20, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants