Update email when linking respondent

[rebecarubio]

Description

This PR adds a dialog to allow the user to add the respondent email to the person that is going to be link as a new respondent.
It also introduces a new extra reducer in the Survey store that updates de submission list when a person is updated.

Screenshots

Video.sin.titulo.Hecho.con.Clipchamp.1.mp4

Changes

• Adds an if statement in SurveySubmissionsList when a person to be linked as a respondent doesn't have an email
• Adds a SurveyDialogLink component to display a Dialog when the if statement is triggered
• Adds an extra reducer in Survey store to update the submissions list when personUpdated action is triggered.

Notes to reviewer

None

Related issues

Resolves #2269

[richardolsson]

Nice work! I've seen this work on your screen and I thought it looked great. But then at first I couldn't get it to work for me. Here's what I tried:

1. With the preview build, I went to "Simon Zetterlund" and removed his email. Note that this sets the email to an empty string, which is probably the cause of this bug.
2. I then went to this survey submissions list where there is a submission made using my email address.
3. I tried linking the submission to Simon Zetterlund, which works, but the modal does not open.

I then tried creating a new person instead of using an existing one, and not setting an email to begin with, which does work. It probably works because the email will be null.

I also think that it would be nice to get a designer to look at the modal. Maybe you can just pair up with someone in the office?

Finally, I left a bunch of comments below. The code looks mostly great, but there are some minor things that I think can be improved, and also some that I identified as a learning opportunity – hopefully appreciated. 😊

[richardolsson]

Nice work! Let's get this merged. 💯

[richardolsson]

I think this is much nicer! I believe it could have been made even simpler, by relying on the fact that null and undefined are falsy, like so:

Suggested change

	if (person) {
	const personHasNoEmail = person.email == null || person.email == '';
	if (personHasNoEmail && respondentEmail != undefined) {
	if (person) {
	const personHasNoEmail = !person.email || person.email == '';
	if (personHasNoEmail && respondentEmail) {

But that's not worth changing the code over!