Fix bug where newly created tags were not added to store #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaulfield23
approved these changes
Dec 14, 2023
| const tagFuture = await apiClient | ||
| .post<ZetkinTag, ZetkinTagPostBody>( | ||
| `/api/orgs/${orgId}/people/tags`, | ||
| tag | ||
| ) | ||
| .then((data: ZetkinTag) => { | ||
| // dispatch(tagGroupCreated); |
There was a problem hiding this comment.
I can't believe I left this 😨 Thanks for catching this!!
|
Tested it and it works as I expected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an undocumented bug introduced by the hook refactor, which caused new tags to not be added to the store, which in turn meant that they would not show up in tag lists until the user refreshes the page (or the cache is invalidated after five minutes). This only happened to ungrouped tags, due to a forgotten comment. Grouped tags still worked as expected.
Screenshots
None
Changes
Notes to reviewer
None
Related issues
Undocumented