issue-1687/sorted orgs in menu #1706
Conversation
| const sortedTreeItems = useMemo(() => { | ||
| const sorted = treeItemData.sort((a, b) => a.title.localeCompare(b.title)); | ||
| return sorted; | ||
| }, [treeItemData.length]); |
There was a problem hiding this comment.
Correct me if I'm wrong, but I believe this only sorts the top-level, which is not enough. We also want to sort the children of each organization, and all of the children of those children, etc.
There was a problem hiding this comment.
Aaaah yeah you are right. I will add more logic to it!
There was a problem hiding this comment.
I believe the best solution would be to handle the sorting in the rendering of each "level", rather than here in the top-level.
There was a problem hiding this comment.
Nice work! The code looks mostly good and I have verified that it works as expected. You can decide if you want to merge or change the variable name issue I've pointed out below.
I foresee this code being refactored in the near future, so you don't have to fix the problem below if you struggle to find the time for it.
Description
This PR sorts organizations alphabetically in menu
Screenshots
Changes
useMemoand sort listNotes to reviewer
used
useMemoto prevent the sorting from being triggered every time user moves a cursor to the sidebar.Related issues
Resolves #1687