issue-1686/navigate event #1704
Conversation
src/core/store.ts
Outdated
| effect: (action) => { | ||
| const event = action.payload; | ||
| Router.push( | ||
| `/organize/${event.organization?.id}/projects/${event.campaign?.id}/events/${event.id}` |
There was a problem hiding this comment.
This breaks when creating an event that isn't part of a project, like this:
- Go to /orgs/1/projects/calendar (the global calendar)
- Go to week view
- Drag to create a block in the calendar
- Click "Create single event"
Expected results:
Should navigate to new event page.
Actual results:
Navigates to new event page, but then also quickly after navigates to URL where campaign ID is undefined (e.g. /organize/1/projects/undefined/events/82).
There is already code on main to redirect to a newly created event after creating it in the calendar. That code does not use this middleware approach. I'm not sure which I prefer, but regardless, there should only be one piece of code that does the same thing (right now two redirects are happening).
And regardless of where the redirect happens, it needs to account for events outside of projects. The easiest way to do that is to use the getEventUrl() utility function.
There was a problem hiding this comment.
Aha that was why there was no middleware for eventCreated! Thank you!
| @@ -20,6 +21,10 @@ export default function useCreateEvent(orgId: number): useCreateEventReturn { | |||
| eventBody | |||
| ); | |||
| dispatch(eventCreated(event)); | |||
| env.router.push( | |||
| `/organize/${orgId}/projects/${event.campaign?.id}/events/${event.id}` | |||
There was a problem hiding this comment.
I think we should always use the getEventUrl() utility to generate event URLs.
Description
This PR fixes a bug that page doesn't navigate to newly created event page.
Screenshots
My.winter.project.Mozilla.Firefox.2023-12-13.16-04-19.mp4
Changes
listenerMiddlewareNotes to reviewer
Related issues
Resolves #1686