sub_query Smart Search filter crashes if org has no smart searches yet. #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one, render message.
Comment on lines
+131
to
+133
| queries.length == 0 ? ( | ||
| <Msg id={messageIds.filters.subQuery.noSmartSearches} /> | ||
| ) : ( |
There was a problem hiding this comment.
What happens when there are no standalone smart search queries (queries) but there are call assignments?
There was a problem hiding this comment.
This filter already takes callassignments into consideration, the queries variable here is an array made up of standalone queries, call assignment target queries, and call assignment "done" queries:
There was a problem hiding this comment.
Ah, I went looking for it but clearly not thoroughly enough. Thanks for clarifying!
richardolsson
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Thank you @ziggabyte for pointing out what I missed. I'm happy with this now that I understand it fully!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the UI would crash when rendering the Smart search filter form for
sub_query, by actually testing if there are queries to select from and if there are none, render a message instead.Screenshots
Changes
Related issues
Resolves #1690