Skip to content

Commit

Permalink
coderabbit feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
gartnera committed Nov 13, 2024
1 parent bbfe7f2 commit 1d5fa39
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions zetaclient/chains/evm/signer/signer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"testing"

sdktypes "github.com/cosmos/cosmos-sdk/types"
"github.com/ethereum/go-ethereum/common"
ethcommon "github.com/ethereum/go-ethereum/common"
ethtypes "github.com/ethereum/go-ethereum/core/types"
"github.com/rs/zerolog"
Expand Down Expand Up @@ -117,7 +116,7 @@ func getInvalidCCTX(t *testing.T) *crosschaintypes.CrossChainTx {
//
// signer.Sender() will ecrecover the public key of the transaction internally
// and will fail if the transaction is not valid or has been tampered with
func verifyTxSender(t *testing.T, tx *ethtypes.Transaction, expectedSender common.Address, signer ethtypes.Signer) {
func verifyTxSender(t *testing.T, tx *ethtypes.Transaction, expectedSender ethcommon.Address, signer ethtypes.Signer) {
senderAddr, err := signer.Sender(tx)
require.NoError(t, err)
require.Equal(t, expectedSender.String(), senderAddr.String())
Expand Down

0 comments on commit 1d5fa39

Please sign in to comment.