Feature/blocks #3087
Feature/blocks #3087
Conversation
| @@ -283,10 +283,16 @@ export const Field = ({ | |||
| return ( | |||
| <AIFieldShell | |||
| ZUID={fieldData?.ZUID} | |||
| name={fieldData?.name} | |||
There was a problem hiding this comment.
This change strike me as odd. How does this relate to blocks? How is the name variable available? If it was already available, why add it now as an or condition?
There was a problem hiding this comment.
I'm seeing that this component is being used in the blocks app. I guess I'm not sure why there is a difference in the props.
There was a problem hiding this comment.
Good question. Yes the name and label are passed as props from parent but in this datatype field we ignore those props and get the same data directly from the field data.
Why this was problematic for blocks is because there is a custom field for "variant title" and it should respect the parent props as it is not a field actually existent in the model
Reasoning why I didn't opt to go fully for dropping fieldData?.name in favor for name is to minimize code change footprint and any potential edge cases
|
|
||
| url = `${url}?_bypassError=true&__version=${props.version}`; |
There was a problem hiding this comment.
Does this need to be extracted? Are there other code paths that need item URL determination?
| import noSearchResults from "../../../../../../../../public/images/noSearchResults.svg"; | ||
| import blockPlaceholder from "../../../../../../../../public/images/blockPlaceholder.png"; | ||
| export const BlockTabs = (props: any) => { | ||
| const [value, setValue] = useState(0); |
There was a problem hiding this comment.
This is hard to understand immediately. "Value" is to generic. What is the context of this value?
This jumped out to me when it is equated later. value == 0. Very hard to know what that means beyond it's literal evaluation.
There was a problem hiding this comment.
Noted. Used for active tab state but yea not clear.
| @@ -78,7 +79,13 @@ export const DuplicateItemDialog = ({ onClose }: DuplicateItemProps) => { | |||
| }) | |||
| .unwrap() | |||
| .then((res) => { | |||
| history.push(`/content/${modelZUID}/${res.data.ZUID}`); | |||
| history.push( | |||
There was a problem hiding this comment.
This is the second place I've seen this logic. Should this be extracted?
There was a problem hiding this comment.
@shrunyan Good point. Extracting these into url generator helper functions would be a great idea
No description provided.