Do not log network errors to sentry #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalin920
requested changes
Nov 25, 2024
| store.dispatch(notify({ message: err.message, kind: "warn" })); | ||
| Sentry.captureException(err, { fingerprint: ["network_error"] }); |
There was a problem hiding this comment.
This line is meant to fingerprint the error in order to aggregate them. The error is still being thrown below this line.
An unhandled promise rejection is typically treated as an unhandled error by Sentry so this doesn't resolve what the PR aims to resolve.
All this change would do is de-aggregate them and make more noise
There was a problem hiding this comment.
@agalin920 I see. I assume removing the throw error below this line would be enough? We're already dispatching a notification in the UI when this happens anyway.
finnar-bin
force-pushed
the
fix/3074-failed-to-fetch
branch
from
c29952a to
f9cc467
Compare
agalin920
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3074