[Content] Support dedicated TC Image field in SEO tab #3044
Conversation
finnar-bin
added
enhancement
| ?.filter((el: string) => el)?.[0]; | ||
|
|
||
| if (tcImage.startsWith("3-")) { | ||
| getFile(String(item.data.tc_image), true) |
There was a problem hiding this comment.
Cant we use the resolver here?
There was a problem hiding this comment.
Oh yeah, I needed to check if the zuid actually contains an image first, if not use the existing meta image. This reminds me to actually add that check which I forgot, I'll be making another commit to add it.
There was a problem hiding this comment.
Updated to add the check I mentioned above
There was a problem hiding this comment.
Hmm why not just use html image onError callback? that would suffice to tell if its not an image right?
| ?.filter((el: string) => el)?.[0]; | ||
|
|
||
| if (tcImage.startsWith("3-")) { | ||
| getFile(String(item.data.tc_image), true) |
There was a problem hiding this comment.
Hmm why not just use html image onError callback? that would suffice to tell if its not an image right?
That something I actually haven't thought off, lemme check that out |
|
@agalin920 updated to use the image resolver |
Resolves #3021
Preview