-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2565 https://github.com/zesty-io/manager-ui/assets/28705606/5f2bee49-07ed-4cfd-aa1d-8e0534d91b0b Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
…llipsis conditions depending on what notification will be displayed.
Co-authored-by: Nar Cuenca <narc.ph@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Solution to handle immediate need of applying an Instance granular role with publish: false Required changes: 1. Content items only get filtered if at least one granular role targets a content item. This ensures that given ONLY an instance granular role a user is still able to see all the content items. 2. Use-permission hook now defaults zuid argument to instance zuid (argument has been unused so far) in order to check permissions. This allows for an instance granular role to be checked and have priority over system role in the case no other entity zuid is provided
Fixes #2565 https://github.com/zesty-io/manager-ui/assets/28705606/5f2bee49-07ed-4cfd-aa1d-8e0534d91b0b Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar Cuenca <narc.ph@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Solution to handle immediate need of applying an Instance granular role with publish: false Required changes: 1. Content items only get filtered if at least one granular role targets a content item. This ensures that given ONLY an instance granular role a user is still able to see all the content items. 2. Use-permission hook now defaults zuid argument to instance zuid (argument has been unused so far) in order to check permissions. This allows for an instance granular role to be checked and have priority over system role in the case no other entity zuid is provided
…https://github.com/zesty-io/manager-ui into feat/text-bold-before-semicolon-global-notifications
**This is dependent on BE Change: [insert pr here]** https://github.com/zesty-io/manager-ui/assets/28705606/80fd0937-9c61-427d-b1da-7e3f34263776 --------- Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Andres Galindo <agalin920@gmail.com>
**This is dependent on BE Change: [insert pr here]** https://github.com/zesty-io/manager-ui/assets/28705606/80fd0937-9c61-427d-b1da-7e3f34263776 --------- Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Andres Galindo <agalin920@gmail.com>
Created by Github action
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.