Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta #3015

Merged
merged 171 commits into from
Oct 16, 2024
Merged

Beta #3015

merged 171 commits into from
Oct 16, 2024

Conversation

shrunyan
Copy link
Contributor

No description provided.

finnar-bin and others added 30 commits June 13, 2024 22:34
…llipsis conditions depending on what notification will be displayed.
Co-authored-by: Nar Cuenca <narc.ph@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Solution to handle immediate need of applying an Instance granular role
with publish: false

Required changes:

1. Content items only get filtered if at least one granular role targets
a content item. This ensures that given ONLY an instance granular role a
user is still able to see all the content items.

2. Use-permission hook now defaults zuid argument to instance zuid
(argument has been unused so far) in order to check permissions.

This allows for an instance granular role to be checked and have
priority over system role in the case no other entity zuid is provided
Co-authored-by: Nar Cuenca <narc.ph@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Solution to handle immediate need of applying an Instance granular role
with publish: false

Required changes:

1. Content items only get filtered if at least one granular role targets
a content item. This ensures that given ONLY an instance granular role a
user is still able to see all the content items.

2. Use-permission hook now defaults zuid argument to instance zuid
(argument has been unused so far) in order to check permissions.

This allows for an instance granular role to be checked and have
priority over system role in the case no other entity zuid is provided
**This is dependent on BE Change: [insert pr here]**


https://github.com/zesty-io/manager-ui/assets/28705606/80fd0937-9c61-427d-b1da-7e3f34263776

---------

Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
**This is dependent on BE Change: [insert pr here]**


https://github.com/zesty-io/manager-ui/assets/28705606/80fd0937-9c61-427d-b1da-7e3f34263776

---------

Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Created by Github action
agalin920 and others added 28 commits July 30, 2024 12:32
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@shrunyan shrunyan merged commit 51d5199 into master Oct 16, 2024
2 checks passed
Copy link

sentry-io bot commented Oct 17, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: undefined is not an object (evaluating 'n.map') bj(src/apps/content-editor/src/app/views/ItemEd... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants