Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content] Resolve relational field zuids with the actual field values #2922

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

finnar-bin
Copy link
Contributor

  • Makes sure that one_to_one and one_to_many field values are properly resolved to whatever the actual text is.
  • This also makes sure that each individual one_to_one and one_to_many chip no longer has to do an api call to retrieve their data

Resolves #2901

Demo

image

@finnar-bin finnar-bin added bug Something isn't working ready PR is complete and ready for deployment labels Aug 8, 2024
@finnar-bin finnar-bin requested a review from agalin920 August 8, 2024 04:39
@finnar-bin finnar-bin self-assigned this Aug 8, 2024
@finnar-bin finnar-bin marked this pull request as ready for review August 8, 2024 04:39
@finnar-bin finnar-bin enabled auto-merge (squash) August 8, 2024 05:00
@finnar-bin finnar-bin disabled auto-merge August 12, 2024 22:54
@agalin920
Copy link
Contributor

We resolve relationship field values (content item zuids) to the respective meta title of that content item. If meta title not present then ZUID is shown.

To resolve this issue user should add meta title values to their content items.

The reason why this DOES resolve in content edit page is because the logic of how the relationship field values gets resolved differs and resolves into the specific field values as set in the field settings

@finnar-bin
Copy link
Contributor Author

@agalin920 I believe the solution I have here is enough to address the comments on the original ticket

@finnar-bin finnar-bin requested a review from agalin920 August 27, 2024 02:27
@agalin920 agalin920 merged commit ebf62ab into dev Aug 27, 2024
1 check passed
@agalin920 agalin920 deleted the fix/2901-resolve-relational-field-titles branch August 27, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PR is complete and ready for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset table will display ZUID of some related items (but not all)
2 participants