Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2432 add field tooltip styling #2540

Merged
merged 14 commits into from
Apr 11, 2024
Merged

Fix/2432 add field tooltip styling #2540

Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
940dcfd
schema: rename integer field to number field
jomarmontuya Feb 7, 2024
3245ff4
schema: Add field tooltip styles update
jomarmontuya Feb 7, 2024
6016e7a
revert previous commit
jomarmontuya Feb 7, 2024
80c78c4
style: update font variant
jomarmontuya Feb 8, 2024
0256777
style: update color only for header text
jomarmontuya Feb 12, 2024
bd10515
add padding bottom to headings
jomarmontuya Feb 26, 2024
211bb6f
update typography to use P instead of span element
jomarmontuya Feb 28, 2024
7c51cb0
remove enforcing p tag on body3 and do theme chagne instead
jomarmontuya Mar 4, 2024
77ebbb5
revert version
jomarmontuya Mar 4, 2024
86b8315
fix package lock version
jomarmontuya Mar 4, 2024
7ec4cda
merge dev
shrunyan Apr 4, 2024
148b0b9
Merge branch 'dev' into fix/2432-add-field-tooltip-styling
shrunyan Apr 10, 2024
c3ceabb
update package-lock
shrunyan Apr 11, 2024
c46c2f7
merge dev
shrunyan Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/apps/schema/src/app/components/AddFieldModal/TooltipBody.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ export const TooltipBody = ({
primaryTypographyProps={{
fontSize: 14,
fontWeight: 700,
color: "text.primary",
lineHeight: "20px",
}}
secondaryTypographyProps={{
variant: "body3",
Expand All @@ -66,7 +68,12 @@ export const TooltipBody = ({
{description}
</Typography>
<Box py={2}>
<Typography variant="body2" fontWeight="700">
<Typography
lineHeight={"20px"}
color="text.primary"
variant="body2"
fontWeight="700"
>
Common Uses
</Typography>
<Box pl={2} component="ul">
Expand All @@ -82,7 +89,12 @@ export const TooltipBody = ({
))}
</Box>
</Box>
<Typography variant="body2" fontWeight="700">
<Typography
lineHeight={"20px"}
color="text.primary"
variant="body2"
fontWeight="700"
>
Pro Tip
</Typography>
<Typography variant="body3" color="text.secondary">
Expand Down
Loading