New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `Clone` conformance to `WeakSender` #136

Merged

zesterer merged 1 commit into zesterer:master from bwoods:master

Nov 28, 2023

Contributor

bwoods commented Nov 28, 2023 •

edited

Loading

Other Weak implementations (e.g. sync::Weak and tokio::WeakSender) implement Clone, so I think this change is uncontroversial.

Since self.shared is already Clone the change is trivial.


          Add Clone conformance to WeakSender

18b0963

Owner

zesterer commented Nov 28, 2023

Yes, this seems very reasonable. Thanks!

zesterer merged commit fcf3849 into zesterer:master

4 checks passed

Contributor Author

bwoods commented Nov 28, 2023

Thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet