Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple and multiline notes support #88

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Add multiple and multiline notes support #88

merged 1 commit into from
Oct 13, 2024

Conversation

Amejonah1200
Copy link
Contributor

No description provided.

@Amejonah1200
Copy link
Contributor Author

image

image

@Amejonah1200 Amejonah1200 changed the title Add ability to add multiple notes, and also allow multiline notes Add ability to add multiple and multiline notes Apr 15, 2024
@Amejonah1200 Amejonah1200 changed the title Add ability to add multiple and multiline notes Add multiple and multiline notes support Apr 15, 2024
ISSOtm
ISSOtm suggested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a test could be added?

@ISSOtm
Copy link
Contributor

ISSOtm commented May 23, 2024

This would be especially useful as codepan-reporting has such a feature.

zesterer
zesterer requested changes Sep 12, 2024
View reviewed changes
src/write.rs Show resolved Hide resolved
@zesterer
Copy link
Owner

Just needs a rebase now.

@Amejonah1200
Copy link
Contributor Author

Perhaps a test could be added?

@ISSOtm Added tests!

@zesterer
Copy link
Owner

Still conflicts, unfortunately :(

@zesterer zesterer merged commit f67d58a into zesterer:main Oct 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm requested changes

@zesterer zesterer Awaiting requested review from zesterer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amejonah1200 @ISSOtm @zesterer