Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom yaml loaders as callback functions #77

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

grst
Copy link
Contributor

@grst grst commented Oct 1, 2024

This PR adds an additional argument loader_callback to hiyapyco that allows to specify custom yaml loader functions.

Close #74
Close #68
Close #57 (ruamel can trivially be specified as custom callback)

@zerwes
Copy link
Owner

zerwes commented Oct 2, 2024

I am currently on vacation and will take care of it when I get back ...

@zerwes zerwes self-assigned this Oct 18, 2024
Copy link
Owner

@zerwes zerwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @grst for the PR!
I will add some additional tests, esp. targeting ruamel before I will do a new release.
and maybe the _USEDEFAULTYAMLLOADER stuff can be more generic based on this PR ...

@zerwes zerwes merged commit decfaa0 into zerwes:main Oct 18, 2024
5 checks passed
zerwes added a commit that referenced this pull request Oct 19, 2024
zerwes added a commit that referenced this pull request Oct 20, 2024
zerwes added a commit that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants