Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processors/bands uses wrong arguments #641

Closed
zerothi opened this issue Nov 3, 2023 · 0 comments · Fixed by #642
Closed

processors/bands uses wrong arguments #641

zerothi opened this issue Nov 3, 2023 · 0 comments · Fixed by #642

Comments

@zerothi
Copy link
Owner

zerothi commented Nov 3, 2023

Describe the bug
@pfebrer I think the below is pretty self-explanatory.

Code to reproduce problem

/home/docs/checkouts/readthedocs.org/user_builds/sisl/conda/latest/lib/python3.12/site-packages/sisl/viz/processors/bands.py:46: FutureWarning: Passing 'how' as positional argument(s) to dropna was deprecated in version v2023.10.0 and will raise an error two releases later. Please pass them as keyword arguments.
  ).dropna("band", "all")
/home/docs/checkouts/readthedocs.org/user_builds/sisl/conda/latest/lib/python3.12/site-packages/sisl/viz/processors/bands.py:46: FutureWarning:

Passing 'how' as positional argument(s) to dropna was deprecated in version v2023.10.0 and will raise an error two releases later. Please pass them as keyword arguments.
pfebrer added a commit to pfebrer/sisl that referenced this issue Nov 3, 2023
@pfebrer
Deprecated xarray argument
2b29e3b 
Closes zerothi#641
@pfebrer pfebrer mentioned this issue Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecated xarray argument pfebrer/sisl
1 participant
@zerothi