-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pkg-config for including shared libzmq #641
Conversation
a669e89
to
7d7b2e7
Compare
'ldflags': [ | ||
'<!(pkg-config --libs-only-other --libs-only-L libzmq)' | ||
], | ||
'libraries': [ | ||
'<!(pkg-config --libs-only-l libzmq)' | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be guarded for platforms that do not ship pkg-config (e.g. Windows). Also, on Windows, the library is probably called zmq
not libzmq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, makes sense. Will look into it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any updates on this? @jirijakes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed response.
I have not got to it yet but still plan to within next few weeks. Is it okay to keep the PR open in the meantime?
I have migrated the build to CMake/vcpkg. So we no longer maintain a gyp based build. I am gausing that the FreeBSD builds will now be successful under CMake. Let me know if you face any issues. |
Thanks and for your information, @aminya, build on FreeBSD still has issues but of different sort. It appears that the combination of cmake-ts and vcpkg is not supported on FreeBSD and that's where the builds fail now, also with |
Currently on FreeBSD (tried only on 14.1) fails with shared libzmq:
The problem is that linking with
-lzmq
is not sufficient on FreeBSD, it requires-L/usr/local/lib -lzmq
. Using pkg-config might help.After applying this patch, it builds.
On FreeBSD 14.1:
On Linux:
Might help #639 by allowing to use shared libzmq.