Remove use of distutils #1632
Merged
Remove use of distutils #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get_platform() -> cmd.plat_name - distutils.version -> packaging.version - distutils.sysconfig.get_config_var -> sysconfig.get_config_var
isort --py 36 --tc -m 3 setup.py
instead of instantiating new ones with `distutils.ccompiler` which is deprecated with no replacement
when linking bundled libmzq on Windows, access the build dir directly
it doesn't work!
use distutils on Python < 3.9.2
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1620
Mostly easy. Two still-undocumented migrations, which ultimately amount to the same thing: use initialized state in base classes, rather than importing the pieces of the underlying implementation.
self.plat_nameinstead ofutil.get_platform(). I suspect this is just better, as in any rare cases where they disagreed, I think it should be more correct nowself.compilerinstead of callingdistutils.ccompiler.new_compiler. This is tricky to get access to, because we need to runbuild_ext.run()but that only configures a compiler if there's something to compile, so we have to: