Resolve issue #939 #958
Merged
Resolve issue #939 #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug is caused by fq which can terminate pipe before sending all frames of a message first. So sometimes two messages were mixed and this confused ZAP handler. This patch just modifies one pipe parameter so that socket consumes all messages before dropping the pipe.
|
Does this need backporting to 4.0.x stable? |
|
I think so. |
|
This should resolve the DoS issue when a client connects with wrong credentials to a zap enabled server? (It was enough for a client to send one malformed request and the server would crash itself...) |
|
What you describe must be a different bug. Do you have a C example reproducing this bug? Is there an issue for this already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is caused by fq which can terminate pipe before sending all
frames of a message first. So sometimes two messages were mixed and this
confused ZAP handler.
This patch just modifies one pipe parameter so that socket consumes all
messages before dropping the pipe.