cmake WITH_LIBSODIUM option is broken #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boringuy
commented
Feb 22, 2017
•
boringuy
commented
- Fixed the variable name in platform.hpp.in
- Fixed the variable name in platform.hpp.in - Fixed #if check for randombytes_close() when libsodium is used
bluca
reviewed
Feb 22, 2017
src/ctx.cpp
Outdated
| @@ -133,7 +133,7 @@ zmq::ctx_t::~ctx_t () | |||
|
|
|||
| // If we've done any Curve encryption, we may have a file handle | |||
| // to /dev/urandom open that needs to be cleaned up. | |||
| #ifdef ZMQ_HAVE_CURVE | |||
| #if defined (ZMQ_USE_TWEETNACL) | |||
There was a problem hiding this comment.
are you sure about this? sodium has this function too
https://download.libsodium.org/doc/generating_random_data/
There was a problem hiding this comment.
Ah... I fixed this before I fix the CMAKE variable then. So, this error was cause by the same problem. I will change this back. Thanks.
|
Ok. Fixed the pull request, it ends up to be just a one line change in platform.hpp.in |
|
Thanks! For your next contributions, if you have fixup commits, please rebase and squash them into the original one. Also please follow the guidelines set in the PR template for the commit message: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.