When polling and the context is terminated, don't throw ZError.IOException #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #380 (Destroying a context while polling causes java.nio.channels.ClosedChannelException).
Summary of changes in this PR:
When a Poller is created via a context (which is the recommended way to do it; see Allow ZMQ.Context / ZContext to manage closing poll selectors #386),
poller.contextis set to that context so the poller has a reference to it.When
pollresults in a ClosedChannelException or any other ZError.IOException, we check to see if the context is terminated, and if so, we catch the exception and return 0.