Allow zbeacon to resolve ip address to interface or interface name to interface #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: To set the interface used in zyre you must call zyre_set_interface, which ultimately calls zsys_set_interface(). The argument for this call is an interface NAME to use for resolution.
On windows machines trying to determine an interface name is nearly a nightmare as its typically something like "Local Network Interface (1)" or something else long winded. Additionally this can change over time, and its hard for end users to deduce in the first place.
Solution: Allow the argument for zsys_set_interface to be an IP address OR interface name. This allows the end user to use something they can be more certain about (ip address) that is additionally guaranteed to not be randomly changed by the OS.
Ultimately you may wish to also update the docs for the other external functions to explain that IP address strings can be used.