Problem: test-randof breaks cmake/msvc, out of date with zproject, optional deps not used, no API to compress and send/receive data #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: rename to test_randof
Solution: regenerate
Solution: add zstr_send[m]_compress and zstr_recv_compress to the API and add dependency to lz4
Solution: do it
Solution: regenerate
Solution: assert if zmq_msg_init_size returns an error, which can happen when size > 33 bytes due to a malloc failure (OOM). Otherwise the following memcopy will write on random memory.
Solution: install libsystemd-dev and liblz4-dev. Install lz4 on OSX only for the legacy builds as an optimisation. Running brew update takes many minutes and slows down the build considerably, so only do it where it's already been done as the legacy builds require libsodium.
|
How did you managed to add 1024 lines? 😀 |
|
I'm just that good :-D |
|
@jimklimov FYI on the test_random rename - cmake/msvc were not happy with the "-" in the name for some reasons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions: see commits