Problem: ziflist does not support IPv6 #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: fix it, 4 spaces-only
Solution: use link-local all-node fe02::1 as the default to enable out-of-the-box functionality.
Solution: use getnameinfo in s_interface_new to get the string format of the interface address and parameters. Add new (draft) methods ziflist_new_ipv6 and ziflist_reload_ipv6 that also look for IPv6 addresses in order to maintain backward compatibility. Only implemented for operating systems that support getifaddrs, so not with ioctl calls (they support only IPv4) and not on Windows (help needed to implement it).
Solution: add a new (draft) ziflist_is_ipv6 API that returns true/false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: see commits
Given the output would change I added 2 new draft ziflist_new_ipv6 and ziflist_reload_ipv6 to keep backward compatibility.
Not implemented for Windows, help needed!