Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSYS_INTERFACE variable can be a single digit #1602

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

bbdb68
Copy link
Contributor

@bbdb68 bbdb68 commented Jan 12, 2017

problem :
on windows system, in exotic languages, the interfaces names can be complex, include spaces and special characters, making the use of the variable ZSYS_INTERFACE for network interface selection difficult.

solution:
allow the ZSYS_INTERFACE variable to be a single digit, selecting the i-th number interface of the system.
keep the existing behaviour for other values.

can be tested/validated with zbeacon self test

@sappo
Copy link
Member

sappo commented Jan 12, 2017

@bbdb68 for your next contribution it would be great if the problem and solution explanation is part of the commit message instead of the pull request. As the commit messages are part of the git history.

@sappo sappo merged commit 5c32baa into zeromq:master Jan 12, 2017
@bbdb68 bbdb68 deleted the zsys_interface branch January 12, 2017 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants