Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle with read the empty file #4258

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

JiChenSSG
Copy link
Contributor

#4217

Handle with empty file read and the condition that first is the same as last line and with out line break.

@kevwan kevwan self-requested a review July 19, 2024 16:25
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (8690859) to head (cdc9f5a).
Report is 91 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
core/filex/file.go 89.47% <100.00%> (+4.72%) ⬆️

... and 254 files with indirect coverage changes

core/filex/file.go Show resolved Hide resolved
@kevwan kevwan added this pull request to the merge queue Jul 20, 2024
Merged via the queue into zeromicro:master with commit 9de04ee Jul 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants