Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timeout on query should return context.DeadlineExceeded #4060

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: timeout on query should return context.DeadlineExceeded #4060

merged 1 commit into from
Apr 10, 2024

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Apr 10, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (8690859) to head (877b994).
Report is 7 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
core/stores/sqlx/sqlconn.go 100.00% <100.00%> (ø)

... and 254 files with indirect coverage changes

MarkJoyMa
MarkJoyMa approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@MarkJoyMa MarkJoyMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan added this pull request to the merge queue Apr 10, 2024
Merged via the queue into zeromicro:master with commit a66ae0d Apr 10, 2024
6 checks passed
@kevwan kevwan deleted the fix/sqlx-deadline branch April 10, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkJoyMa MarkJoyMa MarkJoyMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevwan @MarkJoyMa