feat: migrate redis breaker into hook #3982

MarkJoyMa · 2024-03-06T13:51:33Z

No description provided.

core/stores/redis/hook.go

codecov · 2024-03-08T04:28:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (2629636) to head (d0cacfe).
Report is 23 commits behind head on master.

Additional details and impacted files

Files	Coverage Δ
core/stores/redis/breakerhook.go	`100.00% <100.00%> (ø)`
core/stores/redis/durationhook.go	`100.00% <100.00%> (ø)`
core/stores/redis/redis.go	`99.82% <ø> (+0.06%)`	⬆️
core/stores/redis/redisclientmanager.go	`93.33% <100.00%> (+12.08%)`	⬆️
core/stores/redis/redisclustermanager.go	`86.84% <100.00%> (+1.12%)`	⬆️

core/stores/redis/breakerhook.go

MarkJoyMa added the do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. label Mar 6, 2024

MarkJoyMa requested a review from kevwan March 6, 2024 13:56

kevwan reviewed Mar 8, 2024

View reviewed changes

core/stores/redis/hook.go Outdated Show resolved Hide resolved

MarkJoyMa added 2 commits March 8, 2024 12:26

feat: migrate redis breaker into hook

575bd12

feat: migrate redis breaker into hook

701be34

kevwan force-pushed the feat/redis_hook_breaker branch from 1f84a02 to 701be34 Compare March 8, 2024 04:26

update

27c7739

MarkJoyMa removed the do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. label Mar 10, 2024

kevwan reviewed Mar 11, 2024

View reviewed changes

core/stores/redis/breakerhook.go Show resolved Hide resolved

Merge remote-tracking branch 'zero/master' into feat/redis_hook_breaker

d0cacfe

kevwan approved these changes Mar 12, 2024

View reviewed changes

kevwan added this pull request to the merge queue Mar 12, 2024

Merged via the queue into zeromicro:master with commit 7d90f90 Mar 12, 2024
6 checks passed