Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UMI to APB converter #147

Merged
merged 5 commits into from
Jul 19, 2024
Merged

UMI to APB converter #147

merged 5 commits into from
Jul 19, 2024

Conversation

azaidy
Copy link
Contributor

@azaidy azaidy commented Jul 19, 2024

No description provided.

@azaidy azaidy requested review from aolofsson and zephray July 19, 2024 18:07
zephray
zephray approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@zephray zephray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code overall looks good to me. One minor question: why isn't this module named umi2apb like both bus bridge/ adapters?

aolofsson
aolofsson reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@aolofsson aolofsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. I agree with Wenting, the old methodology of using "2" is a nice directional hint. I suggest the namge is changed to umi2apb

umi2apb
apb2umi
tl2umi...

aolofsson
aolofsson requested changes Jul 19, 2024
View reviewed changes
@azaidy
Copy link
Contributor Author

azaidy commented Jul 19, 2024

Sorry, my bad. I agree with Wenting, the old methodology of using "2" is a nice directional hint. I suggest the namge is changed to umi2apb

umi2apb apb2umi tl2umi...

Naming change done

@azaidy azaidy requested a review from aolofsson July 19, 2024 20:50
@aolofsson aolofsson merged commit 443ad50 into main Jul 19, 2024
16 checks passed
@aolofsson aolofsson deleted the ali/apb branch July 19, 2024 21:31
@azaidy
Copy link
Contributor Author

azaidy commented Jul 19, 2024 •
edited
Loading

@aolofsson, @zephray
A bit of detail on the latest commit:

  1. Removed UMI atomic support. We can add it at a later date if needed.
  2. Removing atomics resulted in pvalid_r looking identical to penable - so just eliminated pvalid_r and replaced instances of it with penable.
  3. pready was unqualified before which meant that anytime pready went high an outgoing resp was issued. This was fixed by qualifying pready with penable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aolofsson aolofsson aolofsson approved these changes

@zephray zephray zephray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azaidy @aolofsson @zephray