New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SchedulingMonitor #103

Closed

3 tasks done

zero88 opened this issue Jan 12, 2024 · 0 comments · Fixed by #104

Closed

3 tasks done

Improve SchedulingMonitor #103

zero88 opened this issue Jan 12, 2024 · 0 comments · Fixed by #104

Assignees

Labels

Milestone

Owner

zero88 commented Jan 12, 2024 •

edited

Loading

Is your feature request related to a problem? Please describe.

Scheduling Monitor is registered from the client side, there is no guarantee that it is a non-blocking code, and fast enough to run in the default Vertx event loop thread.
The monitor should act as a subscriber on the "execution result" topic => should allow more than one monitor in the scheduler

Describe the solution you'd like

Scheduling monitor is run in the worker executor
Create a delegate monitor that can register multiple scheduling monitors
Create an internal monitor to ensure no unexpected exceptions when distributing the execution result by the registered scheduling monitor

zero88 added the enhancement label

zero88 added this to the 2.0.0 milestone

zero88 self-assigned this

zero88 added a commit that referenced this issue


          feat(#103): add SchedulingMonitorInternal

17cafa1

zero88 added a commit that referenced this issue


          feat(#103): add SchedulingCompositeMonitor

fba966e

zero88 mentioned this issue

Feature/improve scheduling monitor #104

Merged

zero88 closed this as completed in #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment