Skip to content

Commit

Permalink
test: remove duplicate test-child-process-execfilesync-maxBuffer.js
Browse files Browse the repository at this point in the history
In addition correct the comment about what it does.

PR-URL: nodejs#28139
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
joyeecheung committed Jun 12, 2019
1 parent 1f143b8 commit e0fa30f
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 75 deletions.
50 changes: 0 additions & 50 deletions test/parallel/test-child-process-execfilesync-maxBuffer.js

This file was deleted.

48 changes: 23 additions & 25 deletions test/parallel/test-child-process-execfilesync-maxbuf.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict';
require('../common');

// This test checks that the maxBuffer option for child_process.spawnSync()
// This test checks that the maxBuffer option for child_process.execFileSync()
// works as expected.

const assert = require('assert');
const execFileSync = require('child_process').execFileSync;
const { execFileSync } = require('child_process');
const msgOut = 'this is stdout';
const msgOutBuf = Buffer.from(`${msgOut}\n`);

Expand All @@ -16,15 +16,16 @@ const args = [

// Verify that an error is returned if maxBuffer is surpassed.
{
assert.throws(
() => execFileSync(process.execPath, args, { maxBuffer: 1 }),
(e) => {
assert.ok(e, 'maxBuffer should error');
assert.strictEqual(e.errno, 'ENOBUFS');
assert.deepStrictEqual(e.stdout, msgOutBuf);
return true;
}
);
assert.throws(() => {
execFileSync(process.execPath, args, { maxBuffer: 1 });
}, (e) => {
assert.ok(e, 'maxBuffer should error');
assert.strictEqual(e.errno, 'ENOBUFS');
// We can have buffers larger than maxBuffer because underneath we alloc 64k
// that matches our read sizes.
assert.deepStrictEqual(e.stdout, msgOutBuf);
return true;
});
}

// Verify that a maxBuffer size of Infinity works.
Expand All @@ -34,19 +35,16 @@ const args = [
assert.deepStrictEqual(ret, msgOutBuf);
}

// maxBuffer size is 1024 * 1024 at default.
// Default maxBuffer size is 1024 * 1024.
{
assert.throws(
() => {
execFileSync(
process.execPath,
['-e', "console.log('a'.repeat(1024 * 1024))"],
{ encoding: 'utf-8' }
);
}, (e) => {
assert.ok(e, 'maxBuffer should error');
assert.strictEqual(e.errno, 'ENOBUFS');
return true;
}
);
assert.throws(() => {
execFileSync(
process.execPath,
['-e', "console.log('a'.repeat(1024 * 1024))"]
);
}, (e) => {
assert.ok(e, 'maxBuffer should error');
assert.strictEqual(e.errno, 'ENOBUFS');
return true;
});
}

0 comments on commit e0fa30f

Please sign in to comment.