-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to limit changeset size #413
Conversation
53b3989
to
772425a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note that we're returning a HTTP 413 error in PR #413.
b2a8e7c
to
58c0823
Compare
[this fits a bit better here]
|
HTTP status code 413 is matching the Rails implementation. If there's some issue with it, it would have to be changed there as well. I'm using HTTP 413 at the moment to reject large uploads (>50MB), a feature which is not present on Rails. It's not unlikely that some editing apps have no idea how to deal with this status code. |
Well I assume that they will simply display the text message, but that is -very- different than its use being documented and displaying a translated message appropriate to the situation. Note that this is not about informing vandals, but giving unsuspecting normal users a hint they can understand what caused the problem and what is the best action to take. |
I'm going to merge this now, to open up testing for everyone on the dev instance https://master.apis.dev.openstreetmap.org Once it is merged and new binaries are built, can you (@tomhughes) please add a new config setting in https://github.com/openstreetmap/chef/blob/master/cookbooks/dev/templates/default/cgimap.environment.erb
for this new parameter?
|
See #412 for details.
For reviewers out there, please add inline comments as needed. Thanks!
Introduces a new config option:
bbox-size-limit-upload
(boolean value)