Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for brotli response body compression #375

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

mmd-osm
Copy link
Collaborator

@mmd-osm mmd-osm commented Mar 21, 2024

  • Brotli enabled by default in CMakeLists (is this a good idea?)
  • Adds a new package dependency: libbrotli-dev
  • Compression level 5 seems to be a good trade-off between compression rate and processing time.
  • Brotli is the preferred option for Accept-Encoding: gzip, compress, br http header, like on the Rails port/mod_brotli on Apache.
  • Changeset upload decompression is not in scope, maybe we could add this later.

Implementation details:


Closes #374

@mmd-osm mmd-osm marked this pull request as ready for review March 22, 2024 21:42
@mmd-osm
Copy link
Collaborator Author

mmd-osm commented Mar 25, 2024

@tomhughes : before merging this PR, it would be good to know, if libbrotli-dev is available on faffy. Although I don't see it listed in chef, the relevant files such as brotli/decode.h , libbrotlicommon.so.1 and libbrotlienc.so.1 might be pulled in by some other dependency already. TIA.

@tomhughes
Copy link
Contributor

It was actually installed but I've added it to chef anyway.

@mmd-osm mmd-osm merged commit c79e8e3 into zerebubuth:master Mar 25, 2024
6 checks passed
@mmd-osm
Copy link
Collaborator Author

mmd-osm commented Mar 25, 2024

Thanks, I'll give it a try now. If there are some bugs during testing, we'll address them in another PR.

Edit: Looks good, CGImap 0.9.0.2403252213 replied with "content-encoding: br"

@mmd-osm mmd-osm added this to the v0.9.1 milestone Apr 5, 2024
@mmd-osm mmd-osm deleted the feature/brotli branch August 11, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for brotli compression
2 participants