Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch CGRect error on macOS Ventura 13.0 #56

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Catch CGRect error on macOS Ventura 13.0 #56

merged 1 commit into from
Aug 17, 2022

Conversation

borulday
Copy link
Member

@borulday borulday commented Aug 5, 2022

Summary of the changes

size on CGRect fails on Mocha, on macOS Ventura 13.0.

⚠️ Until this issue has been fixed on new versions, the plugin can't warn designers about oversized artboards that could not be exported because of Sketch's limits.

Checklist

  • My PR has a clear and complete description.
  • I have performed a self-review of my own code.
  • I have considered the security implications of this change.
  • I have tested the changes against older versions of Sketch.

@borulday borulday self-assigned this Aug 5, 2022
@emre-aki emre-aki merged commit 39786dd into develop Aug 17, 2022
@emre-aki emre-aki deleted the bugfix/catch-cgrect-error-on-ventura branch August 17, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emre-aki emre-aki emre-aki approved these changes

@gunesmab gunesmab gunesmab approved these changes

@yigitcanyurtsever yigitcanyurtsever yigitcanyurtsever approved these changes

@kardeslik kardeslik kardeslik approved these changes

@hcemozturk hcemozturk hcemozturk approved these changes

Assignees

@borulday borulday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@borulday @hcemozturk @kardeslik @yigitcanyurtsever @gunesmab @emre-aki