Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd +k no longer clears the terminal #90

Closed
bfanger opened this issue Jun 3, 2020 · 2 comments · Fixed by #91
Closed

cmd +k no longer clears the terminal #90

bfanger opened this issue Jun 3, 2020 · 2 comments · Fixed by #91
Assignees
@fonurr
Labels
bug Something isn't working

Comments

@bfanger
Copy link

bfanger commented Jun 3, 2020

When the zeplin extension is enabled the default keybinding cmd + k to clear the focused terminal doesn't work.
fonurr added a commit that referenced this issue Jun 3, 2020
@fonurr
Fix shortcuts blocking Terminal: Clear command
57f86aa 
Clearing terminal command has default shortcut of Cmd+k when terminal
has focus. So Zeplin command is changed to be active only when terminal
is not focused.

Resolves #90
@fonurr fonurr self-assigned this Jun 3, 2020
@fonurr fonurr added the bug Something isn't working label Jun 3, 2020
fonurr added a commit that referenced this issue Jun 3, 2020
@fonurr
Fix shortcuts blocking Terminal: Clear command
99c3cd7 
Clearing terminal command has default shortcut of Cmd+k when terminal
has focus. So Zeplin commands are changed to be active only when terminal
is not focused.

Resolves #90
@fonurr fonurr mentioned this issue Jun 3, 2020
Merged
@fonurr
Copy link
Contributor

fonurr commented Jun 3, 2020

I wasn't aware of this command. Thanks. It is now fixed. It will be live on the next release

@bfanger
Copy link
Author

bfanger commented Jun 3, 2020

👍

@bfanger bfanger closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fonurr fonurr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shortcuts blocking Terminal: Clear command zeplin/vscode-extension
2 participants
@bfanger @fonurr