Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running login command when there is no existing token #90

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Fix running login command when there is no existing token #90

merged 1 commit into from
Jun 3, 2021

Conversation

skarahoda
Copy link

Change description

Previously, cli did nothing when there is no stored token. With this PR, cli prompts for login for both cases.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@skarahoda skarahoda requested review from yuqu and a team June 2, 2021 13:30
@skarahoda skarahoda self-assigned this Jun 2, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@skarahoda skarahoda merged commit b2f6579 into master Jun 3, 2021
@skarahoda skarahoda deleted the bugfix/login branch June 3, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqu yuqu yuqu approved these changes

@Helehelehele Helehelehele Helehelehele approved these changes

Assignees

@skarahoda skarahoda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skarahoda @Helehelehele @yuqu