Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-updating development mode on file changes #19

Merged
merged 10 commits into from
Jan 21, 2020
Merged

Auto-updating development mode on file changes #19

merged 10 commits into from
Jan 21, 2020

Conversation

yuqu
Copy link
Contributor

@yuqu yuqu commented Jan 20, 2020

No description provided.

@yuqu yuqu requested review from dirtybit and ergunsh January 20, 2020 13:24
ergunsh
ergunsh suggested changes Jan 20, 2020
View reviewed changes
Copy link

@ergunsh ergunsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting changes for only resolving the componentFiles paths with respect to given config path since users can start CLI from a place other than the root directory of the project.

Others are to discuss and good to have.

src/commands/connect/index.ts Show resolved Hide resolved
src/commands/connect/index.ts Outdated Show resolved Hide resolved
src/commands/connect/index.ts Outdated Show resolved Hide resolved
src/commands/connect/index.ts Outdated Show resolved Hide resolved
src/commands/connect/index.ts Outdated Show resolved Hide resolved
src/commands/connect/index.ts Outdated Show resolved Hide resolved
@yuqu yuqu requested a review from ergunsh January 20, 2020 15:39
@yuqu
Copy link
Contributor Author

yuqu commented Jan 20, 2020

@ergunsh I had some issues about chokidar.unwatch during the first iteration of my implementation but now I could easily refactor the final implementation not to restart watcher and the dev server without any issues somehow 🤔. Thanks for the suggestion 🎉

@yuqu yuqu merged commit bc2efaf into master Jan 21, 2020
@yuqu yuqu deleted the watch-dev-mode branch January 21, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ergunsh ergunsh ergunsh approved these changes

@dirtybit dirtybit Awaiting requested review from dirtybit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuqu @ergunsh