Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging #17

Merged
merged 7 commits into from
Jan 17, 2020
Merged

Logging #17

merged 7 commits into from
Jan 17, 2020

Conversation

yuqu
Copy link
Contributor

@yuqu yuqu commented Jan 15, 2020

Addressed comments on #15

@yuqu yuqu requested a review from ergunsh January 15, 2020 19:39
@yuqu yuqu changed the base branch from tests to master January 17, 2020 08:10
ergunsh
ergunsh suggested changes Jan 17, 2020
View reviewed changes
Copy link

@ergunsh ergunsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes due to the need of masking the URL in Location header of responses since our authorization flow can pass sensitive values in the URL.

Also, we need to stringify error.details since it can be an object too.

src/api/interceptors.ts Show resolved Hide resolved
src/util/command.ts Outdated Show resolved Hide resolved
@yuqu yuqu requested a review from ergunsh January 17, 2020 13:49
@yuqu yuqu merged commit a0530c8 into master Jan 17, 2020
@yuqu yuqu deleted the logging branch January 17, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ergunsh ergunsh ergunsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuqu @ergunsh