Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show an update notification if new version exists #16

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Show an update notification if new version exists #16

merged 1 commit into from
Jan 20, 2020

Conversation

yuqu
Copy link
Contributor

@yuqu yuqu commented Jan 15, 2020

No description provided.

@yuqu yuqu assigned dirtybit and ergunsh and unassigned dirtybit and ergunsh Jan 15, 2020
@yuqu yuqu requested review from dirtybit and ergunsh January 15, 2020 09:13
@yuqu yuqu force-pushed the logging branch 2 times, most recently from 7b0a1ab to a2d1c69 Compare January 15, 2020 19:16
@yuqu yuqu force-pushed the update-notification branch 2 times, most recently from 24779ae to 33f5416 Compare January 15, 2020 19:29
@yuqu yuqu force-pushed the logging branch 2 times, most recently from f0aec66 to 1347247 Compare January 15, 2020 19:37
@yuqu yuqu force-pushed the update-notification branch from 33f5416 to 435fa70 Compare January 15, 2020 19:38
@yuqu yuqu force-pushed the update-notification branch from 435fa70 to c3c4c39 Compare January 17, 2020 14:53
@yuqu yuqu force-pushed the update-notification branch from c3c4c39 to dab0775 Compare January 17, 2020 14:53
@yuqu yuqu changed the base branch from logging to master January 17, 2020 14:54
dirtybit
dirtybit approved these changes Jan 18, 2020
View reviewed changes
Copy link

@dirtybit dirtybit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:kop: We can use this in zem as well.

@yuqu yuqu merged commit 463df24 into master Jan 20, 2020
@yuqu yuqu deleted the update-notification branch January 20, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtybit dirtybit dirtybit approved these changes

@ergunsh ergunsh Awaiting requested review from ergunsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuqu @dirtybit @ergunsh