Add USB FS (USBFS0) support on NXP MCX N94x #84590
Conversation
zephyrbot
added
platform: NXP Drivers
zephyrbot
requested review from
butok,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
jfischer-no,
manuargue,
mmahadevan108,
tmon-nordic and
yvanderv
alxrey
force-pushed
the
mcxn947-usbfs0
branch
from
96ddd1d to
b3f6802
Compare
dts/arm/nxp/nxp_mcxn23x_common.dtsi
Outdated
There was a problem hiding this comment.
Please check the commit message as the change is made to mcxn23x file.
There was a problem hiding this comment.
Sorry, I modified the wrong file. It's my bad.
boards/nxp/frdm_mcxn947/board.c
Outdated
| CLOCK_EnableClock(kCLOCK_Usb0Ram); | ||
| CLOCK_EnableClock(kCLOCK_Usb0Fs); | ||
| CLOCK_EnableUsbfsClock(); | ||
| #endif |
There was a problem hiding this comment.
How was this tested?
There was a problem hiding this comment.
With a custom board that I made...
You're right, on the FRDM board the USB0 pins are only connected to two TP. Therefore it is not pertinent to put this configuration in the board.c file.
But why all these configurations are not done in a soc.c file, "at the soc level"?
There was a problem hiding this comment.
We are moving to making the clock configuration board specific as these should be managed at a board level. Kindly delete this from board.c
There was a problem hiding this comment.
It is a bit a shame because it means that if someone wants to create a custom board based on this soc, he necessarily needs to do some research how to use the HAL.
But I also understand the intention to manage it at the board level, I will remove this modification.
USBFS0 configuration is missing in Devicetree for NXP MCX N94x. Add the configuration to dtsi file. Signed-off-by: Alexandre Rey <alx.rey@icloud.com>
alxrey
force-pushed
the
mcxn947-usbfs0
branch
from
b3f6802 to
565a77a
Compare
|
Please help address the CI failures |
alxrey
force-pushed
the
mcxn947-usbfs0
branch
from
565a77a to
92e7fd4
Compare
alxrey
changed the title
Some NXP socs use USBFS0 macro as base address for accessing the USB registers, rather than USB0. It generates compile-time errors, since USB0 is not defined. Fix by defining USB0 if USB0 is not defined and USBFS0 is. Signed-off-by: Alexandre Rey <alx.rey@icloud.com>
alxrey
force-pushed
the
mcxn947-usbfs0
branch
from
92e7fd4 to
51043b6
Compare
There was a problem hiding this comment.
I am not sure if it is the best way to handle this. we could also run conditional checks on the soc used.
Opened to be discussed...
There was a problem hiding this comment.
@alxrey. Zephyr is USB support is going through a rework. Below is the new driver we should be using for this IP.
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/usb/udc/udc_kinetis.c
Eventually this driver will be deprecated. I would suggest testing and using the above driver.
This is the issue that is tracking progress on the USB rework.
#42066
| * In some SoC USB0 base register is defined as USBFS0 | ||
| */ | ||
| #if !defined(USB0) && defined(USBFS0) | ||
| #define USB0 USBFS0 |
There was a problem hiding this comment.
Just a note, #define USB0 (USB_Type *)DT_INST_REG_ADDR(0) should work as well (not tested 😄).
zephyr/drivers/usb/udc/udc_kinetis.c
Line 1182 in b80a058
|
Hi @alxrey! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Add USB FS support on NXP mcx n94x soc: