storage/stream_flash: Initialize settings at point of use #81867
+26
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
stream-flash-move-settings-out
branch
from
34db2cf to
c55e711
Compare
The commit moves Settigns initialization out of stream_flash initialization function into: stream_flash_progress_clear stream_flash_progress_load and stream_flash_progress_save. This slightly increases code size (~56 bytes on Arm) but allows to initialize Stream Flash even if Settings subsystem fails to initialize and continue providing its basic functionality. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
stream-flash-move-settings-out
branch
from
c55e711 to
00810c3
Compare
|
@de-nordic could you add some reviewers you feel would be appropriate? thanks |
I am trying to find someone interested in this. I mean using the feature. |
|
Would it than make sense to remove the |
|
hawkbit is going to make use of that, as soon as this can be merged: #71954 |
Yes, it does. Thanks, I will fix that. |
1 similar comment
Yes, it does. Thanks, I will fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit moves Settigns initialization out of stream_flash initialization function into: stream_flash_progress_clear
stream_flash_progress_load and stream_flash_progress_save.
This slightly increases code size (~56 bytes on Arm) but allows to initialize Stream Flash even if Settings subsystem fails to initialize and continue providing its basic functionality.