sca: Add cppcheck (FOSS and premium) #80961
Draft
+109
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettichschnidi
force-pushed
the
gardena/rs/upstream/sca-cppcheck
branch
2 times, most recently
from
a1554b5 to
e8355ad
Compare
|
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with metadata changes and 1 unreachable repo Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-cmsis
DNM
kartben
reviewed
Nov 27, 2024
cmake/sca/cppcheck/sca.cmake
Outdated
| find_program(CPPCHECK_EXE NAMES cppcheck REQUIRED) | ||
| message(STATUS "Found SCA: cppcheck (${CPPCHECK_EXE})") | ||
|
|
||
| # CodeChecker uses the compile_commands.json as input |
There was a problem hiding this comment.
Addressed. Thanks!
cmake/sca/cppcheck/sca.cmake
Outdated
| COMMAND | ||
| ${CPPCHECK_HTMLREPORT_EXE} --title=Zephyr | ||
| --file=${output_dir}/cppcheck.xml # Read in file created by cppcheck | ||
| --report-dir=${output_dir} # Set output director # Set output directory |
There was a problem hiding this comment.
Suggested change
| --report-dir=${output_dir} # Set output director # Set output directory | |
| --report-dir=${output_dir} # Set output directory |
There was a problem hiding this comment.
Addressed. Thanks!
rettichschnidi
force-pushed
the
gardena/rs/upstream/sca-cppcheck
branch
2 times, most recently
from
9db0694 to
b917536
Compare
rettichschnidi
force-pushed
the
gardena/rs/upstream/sca-cppcheck
branch
2 times, most recently
from
d703fb8 to
c4e5050
Compare
This commit adds cppcheck as a Static Analyser using Zephyr's SCA framework. By specifing -DZEPHYR_SCA_VARIANT=cppcheck to west build, the file sca/cppcheck/index.html will be generated. Signed-off-by: Reto Schneider <reto.schneider@husqvarnagroup.com>
This change allows cppcheck to go past the compiler check macros. Signed-off-by: Reto Schneider <reto.schneider@husqvarnagroup.com>
This is a proper finding by cppcheck. Remove the code for now because it blocks finding of other issues.
Putting #ifdef inside a macro invocation is undefined behavior. Signed-off-by: Reto Schneider <reto.schneider@husqvarnagroup.com>
This is needed to allow Cppcheck to work.
Putting #ifdef inside a macro invocation is undefined behavior. Signed-off-by: Reto Schneider <reto.schneider@husqvarnagroup.com>
rettichschnidi
force-pushed
the
gardena/rs/upstream/sca-cppcheck
branch
from
c4e5050 to
8b98c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use cppcheck directly, without going trough CodeChecker.
TODO:
-j <n>)include/zephyr/kernel/internal/mm.hBackground: I am doing this because I am currently evaluating Cppcheck Premium.