drivers: usb: udc: add Smartbond UDC driver #79184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function dma_smartbond_set_channel_status() used incorrect condition to release state lock. In initialization function dma_smartbond_init() function dma_smartbond_set_channel_status() was called for each DMA channel and tried to release lock that was never taken. Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
zephyrbot
added
area: USB
zephyrbot
requested review from
andrzej-kaczmarek,
blauret,
ioannis-karachalios,
jfischer-no,
teburd,
tmon-nordic and
ydamigos
kasjer
force-pushed
the
kasjer/da1469x-usb-next
branch
from
f375211 to
1ea1e01
Compare
tmon-nordic
reviewed
Sep 30, 2024
kasjer
force-pushed
the
kasjer/da1469x-usb-next
branch
2 times, most recently
from
cd4894c to
9d6522e
Compare
kasjer
force-pushed
the
kasjer/da1469x-usb-next
branch
from
9d6522e to
b95e7f3
Compare
|
Please add |
done |
ydamigos
reviewed
Oct 4, 2024
ydamigos
reviewed
Oct 4, 2024
kasjer
force-pushed
the
kasjer/da1469x-usb-next
branch
from
6356fe9 to
6416c0c
Compare
ydamigos
previously approved these changes
Oct 9, 2024
tmon-nordic
previously approved these changes
Oct 10, 2024
ioannis-karachalios
previously approved these changes
Oct 10, 2024
andrzej-kaczmarek
previously approved these changes
Oct 10, 2024
56 tasks
jfischer-no
requested changes
Oct 16, 2024
kasjer
dismissed stale reviews from andrzej-kaczmarek, ioannis-karachalios, tmon-nordic, and ydamigos
via
386b9a9
kasjer
force-pushed
the
kasjer/da1469x-usb-next
branch
from
6416c0c to
386b9a9
Compare
jfischer-no
reviewed
Oct 17, 2024
kasjer
force-pushed
the
kasjer/da1469x-usb-next
branch
from
386b9a9 to
8294832
Compare
jfischer-no
reviewed
Oct 21, 2024
| LOG_INF("ep 0x%02x dequeue all", ep); | ||
|
|
||
| lock_key = irq_lock(); | ||
|
|
There was a problem hiding this comment.
That looks too easy, do you need to find and cancel DMA transfers in progress?
There was a problem hiding this comment.
Your are right, can you give me a quick tip on how to trigger this case so I can verify that it works correctly?
There was a problem hiding this comment.
Fixed (scenario when this happens not tested though).
There was a problem hiding this comment.
There are few, (There was a simple one using shell commands to enqueue transfers, I have to bring it back). You can try CDC ACM sample, build it with CONFIG_SHELL and CONFIG_USBD_SHELL enabled. On Zephyr side enter shell command usbd select sample_usbd.
python3
>>> import usb
>>> dev = usb.core.find(idVendor=0x2fe3, idProduct=0x0001)
>>> dev.detach_kernel_driver(0)
>>> #to set DTR
>>> dev.ctrl_transfer(0x21, 0x22, 3, 0, 0)
0
>>> #Read all DCD and DSR notifications
>>> dev.read(0x81, 100)
array('B', [161, 32, 0, 0, 0, 0, 2, 0, 1, 0])
>>> dev.read(0x81, 100)
array('B', [161, 32, 0, 0, 0, 0, 2, 0, 3, 0])
>>> #On Zephyr side 'usbd disable' should trigger dequeue transfers for endpoint 0x01
Code adds Smartbond UDC driver to be used with USB next stack. Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
Marks boards da1469x_dk_pro and da14695_dk_usb as supporting new usb driver support Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
kasjer
force-pushed
the
kasjer/da1469x-usb-next
branch
from
8294832 to
59da6f0
Compare
jfischer-no
approved these changes
Oct 21, 2024
ydamigos
approved these changes
Oct 21, 2024
ioannis-karachalios
requested review from
ioannis-karachalios,
tmon-nordic and
andrzej-kaczmarek
ioannis-karachalios
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code adds USB UDC driver for Smartbond device.
Code was NOT tested with ISO endpoints yet.
It was tested with console, mass, and cdc_acm applications
Additionally small fix in DMA power management was needed.
Function dma_smartbond_set_channel_status() used incorrect
condition to release state lock.
In initialization function dma_smartbond_init() function
dma_smartbond_set_channel_status() was called for each DMA
channel and tried to release lock that was never taken.
Fixes #74662
Signed-off-by: Jerzy Kasenberg jerzy.kasenberg@codecoup.pl