Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop old ztest API #63723

Merged
merged 8 commits into from
Oct 20, 2023
Merged

drop old ztest API #63723

merged 8 commits into from
Oct 20, 2023

Conversation

nashif
Copy link
Member

@nashif nashif commented Oct 10, 2023

  • ztest: enable ZTEST_NEW_API by default
  • tests: remove CONFIG_ZTEST_NEW_API in all tests
  • cmsis_dsp: remove handling of old ztest API
  • tests: sensor: do not depend on ZTEST_NEW_API
  • drivers: fake: remove special handling for new ztest APIs
  • ztest: remove old ztest api
  • doc:ztest: adapt ztest docs

@nashif nashif force-pushed the topic/remove_old_ztest_api branch 2 times, most recently from f8defee to 4f84e39 Compare October 10, 2023 12:55
nashif added 4 commits October 16, 2023 14:19
@nashif
ztest: enable ZTEST_NEW_API by default
90c2c89 
Enable by default so we can remove kconfigs from tests/samples and keep
things working as before.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
tests: remove CONFIG_ZTEST_NEW_API in all tests
f78ca8a 
Remove all usage of CONFIG_ZTEST_NEW_API from tests and sample as this
is now enabled by default.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
cmsis_dsp: remove handling of old ztest API
5d43815 
Old ztest API is deprecated, so no need for the conditional code here.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
tests: sensor: do not depend on ZTEST_NEW_API
9b8f519 
Old ztest API is deprecated, so no need for the conditional code here.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif force-pushed the topic/remove_old_ztest_api branch from 4f84e39 to 4ba26d2 Compare October 16, 2023 14:29
@nashif nashif marked this pull request as ready for review October 16, 2023 14:31
@nashif nashif requested a review from a user October 16, 2023 14:31
@nashif
doc: ztest: adapt ztest docs
b16c256 
Remove remaining usage and documenation of dropped kconfig that is now
the default.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif force-pushed the topic/remove_old_ztest_api branch from 47d8acd to 3b042cb Compare October 16, 2023 17:27
nordicjm
nordicjm previously approved these changes Oct 17, 2023
View reviewed changes
@henrikbrixandersen
Copy link
Member

Looks like our bot missed the manifest change in this PR. Marking as DNM until zephyrproject-rtos/zscilib#55 is merged and the manifest updated.

@henrikbrixandersen henrikbrixandersen added DNM This PR should not be merged (Do Not Merge) manifest-zscilib labels Oct 17, 2023
@nashif
Copy link
Member Author

nashif commented Oct 17, 2023

Looks like our bot missed the manifest change in this PR. Marking as DNM until zephyrproject-rtos/zscilib#55 is merged and the manifest updated.

hmm, interesting, @carlescufi any idea why it was missed?

@carlescufi
Copy link
Member

Looks like our bot missed the manifest change in this PR. Marking as DNM until zephyrproject-rtos/zscilib#55 is merged and the manifest updated.

hmm, interesting, @carlescufi any idea why it was missed?

Just identified the issue, will send a PR

@microbuilder
Copy link
Member

Looks like our bot missed the manifest change in this PR. Marking as DNM until zephyrproject-rtos/zscilib#55 is merged and the manifest updated.

hmm, interesting, @carlescufi any idea why it was missed?

Merged

@nashif
manifest: zsclib module sha
8080602 
Remove usage of obsolete Kconfig in module.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif dismissed stale reviews from henrikbrixandersen and nordicjm via 8080602 October 17, 2023 12:14
@nashif nashif force-pushed the topic/remove_old_ztest_api branch from 3b042cb to 8080602 Compare October 17, 2023 12:14
@nashif nashif removed the DNM This PR should not be merged (Do Not Merge) label Oct 17, 2023
@nashif nashif added this to the v3.6.0 milestone Oct 17, 2023
de-nordic
de-nordic approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flash, VFS and MCUmgr OK.

glarsennordic
glarsennordic approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@glarsennordic glarsennordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conn_mgr changes LGTM. No comment on other changes

@carlescufi carlescufi merged commit 488e959 into zephyrproject-rtos:main Oct 20, 2023
24 of 25 checks passed
@ycsin ycsin mentioned this pull request Oct 26, 2023
Merged
aescolar added a commit to aescolar/zephyr that referenced this pull request Oct 26, 2023
@aescolar
tests/drivers/sensor/adltc2990: Remove use of CONFIG_ZTEST_NEW_API
16b3275 
CONFIG_ZTEST_NEW_API was removed in
zephyrproject-rtos#63723

Tests still using it cause compliance failures.
So let's fix it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar added a commit to aescolar/zephyr that referenced this pull request Oct 26, 2023
@aescolar
tests/kconfig/configdefault/prj.conf: Remove use of CONFIG_ZTEST_NEW_API
9a00188 
CONFIG_ZTEST_NEW_API was removed in
zephyrproject-rtos#63723

Tests still using it cause compliance failures.
So let's fix it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar added a commit to aescolar/zephyr that referenced this pull request Oct 26, 2023
@aescolar
tests/drivers/sensor/adltc2990: Remove use of CONFIG_ZTEST_NEW_API
527af02 
CONFIG_ZTEST_NEW_API was removed in
zephyrproject-rtos#63723

Tests still using it cause compliance failures.
So let's fix it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar added a commit to aescolar/zephyr that referenced this pull request Oct 26, 2023
@aescolar
tests/kconfig/configdefault/prj.conf: Remove use of CONFIG_ZTEST_NEW_API
5270918 
CONFIG_ZTEST_NEW_API was removed in
zephyrproject-rtos#63723

Tests still using it cause compliance failures.
So let's fix it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@nordic-krch nordic-krch mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glarsennordic glarsennordic glarsennordic approved these changes

@de-nordic de-nordic de-nordic approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@cfriedt cfriedt cfriedt approved these changes

@ceolin ceolin ceolin approved these changes

@microbuilder microbuilder microbuilder approved these changes

@nordicjm nordicjm nordicjm left review comments

@finikorg finikorg finikorg left review comments

@teburd teburd teburd left review comments

@jakub-uC jakub-uC Awaiting requested review from jakub-uC

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@rlubos rlubos Awaiting requested review from rlubos

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@jukkar jukkar Awaiting requested review from jukkar

@npitre npitre Awaiting requested review from npitre

@jhedberg jhedberg Awaiting requested review from jhedberg

@stephanosio stephanosio Awaiting requested review from stephanosio

@dcpleung dcpleung Awaiting requested review from dcpleung

@andyross andyross Awaiting requested review from andyross

@str4t0m str4t0m Awaiting requested review from str4t0m

@anangl anangl Awaiting requested review from anangl

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter

@mnkp mnkp Awaiting requested review from mnkp

@sjg20 sjg20 Awaiting requested review from sjg20

@d3zd3z d3zd3z Awaiting requested review from d3zd3z

@cvinayak cvinayak Awaiting requested review from cvinayak

@thoh-ot thoh-ot Awaiting requested review from thoh-ot

@kruithofa kruithofa Awaiting requested review from kruithofa

@erbr-ot erbr-ot Awaiting requested review from erbr-ot

@sjanc sjanc Awaiting requested review from sjanc

@Vudentz Vudentz Awaiting requested review from Vudentz

@wopu-ot wopu-ot Awaiting requested review from wopu-ot

@Thalley Thalley Awaiting requested review from Thalley

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@aescolar aescolar Awaiting requested review from aescolar

@daor-oti daor-oti Awaiting requested review from daor-oti

@ioannisg ioannisg Awaiting requested review from ioannisg

@tejlmand tejlmand Awaiting requested review from tejlmand

@mbolivar-ampere mbolivar-ampere Awaiting requested review from mbolivar-ampere

Assignees

@nashif nashif

Labels
manifest-zscilib
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.