Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies for SOC_FLASH_MCUX are incorrect on LPC55xxx platforms #79576

Closed
danieldegrasse opened this issue Oct 8, 2024 · 0 comments · Fixed by #79577
Closed

Dependencies for SOC_FLASH_MCUX are incorrect on LPC55xxx platforms #79576

danieldegrasse opened this issue Oct 8, 2024 · 0 comments · Fixed by #79577
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@danieldegrasse
Copy link
Collaborator

Describe the bug
Samples enabling CONFIG_FLASH fail to build on the LPC55S69 CPU1 target, due to the IAP flash driver being enabled when it should not be.

Please also mention any information which could help others to understand
the problem you're facing:

  • What target platform are you using?
    lpcxpresso55s69/lpc55s69/cpu1
  • Is this a regression? If yes, have you been able to "git bisect" it to a
    specific commit?
    Yes, the introduction of HWMv2

To Reproduce

Expected behavior
Build should pass

Impact
Blocking CI on #72102

Logs and console output

 /__w/zephyr/zephyr/drivers/flash/soc_flash_mcux.c:41:2: error: #error No matching compatible for soc_flash_mcux.c
   41 | #error No matching compatible for soc_flash_mcux.c
      |  ^~~~~
/__w/zephyr/zephyr/drivers/flash/soc_flash_mcux.c:53:10: fatal error: fsl_flash.h: No such file or directory
   53 | #include "fsl_flash.h"
      |          ^~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.

Environment (please complete the following information):

  • OS: Linux
  • Toolchain: Zephyr SDK
  • Commit SHA or Version used: d7ab4f2 (main)
@danieldegrasse danieldegrasse added the bug The issue is a bug, or the PR is fixing a bug label Oct 8, 2024
danieldegrasse added a commit to nxp-upstream/zephyr that referenced this issue Oct 8, 2024
@danieldegrasse
soc: nxp: lpc55xxx: fix dependencies for SOC_FLASH_MCUX
bc06cfb 
SOC_FLASH_MCUX has additional dependencies for LPC55xxx CPUs, due to the
fact that the flash should be disabled when executing in nonsecure mode.

Since the merge of HWMv2, this dependency has been set incorrectly at
the SOC level, resulting in the IAP flash driver being enabled when
targeting CPU1, which is incorrect. Fix the Kconfig dependency to
resolve this issue.

Fixes zephyrproject-rtos#79576

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
@danieldegrasse danieldegrasse mentioned this issue Oct 8, 2024
Merged
@hakehuang hakehuang mentioned this issue Oct 9, 2024
Merged
@nashif nashif closed this as completed in feb0241 Oct 15, 2024
danieldegrasse added a commit to nxp-upstream/zephyr that referenced this issue Oct 15, 2024
@danieldegrasse
soc: nxp: lpc55xxx: fix dependencies for SOC_FLASH_MCUX
68593ec 
SOC_FLASH_MCUX has additional dependencies for LPC55xxx CPUs, due to the
fact that the flash should be disabled when executing in nonsecure mode.

Since the merge of HWMv2, this dependency has been set incorrectly at
the SOC level, resulting in the IAP flash driver being enabled when
targeting CPU1, which is incorrect. Fix the Kconfig dependency to
resolve this issue.

Fixes zephyrproject-rtos#79576

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
(cherry picked from commit feb0241)
@danieldegrasse danieldegrasse mentioned this issue Oct 15, 2024
Merged
nashif pushed a commit that referenced this issue Oct 18, 2024
@danieldegrasse @nashif
soc: nxp: lpc55xxx: fix dependencies for SOC_FLASH_MCUX
da137a5 
SOC_FLASH_MCUX has additional dependencies for LPC55xxx CPUs, due to the
fact that the flash should be disabled when executing in nonsecure mode.

Since the merge of HWMv2, this dependency has been set incorrectly at
the SOC level, resulting in the IAP flash driver being enabled when
targeting CPU1, which is incorrect. Fix the Kconfig dependency to
resolve this issue.

Fixes #79576

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
(cherry picked from commit feb0241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

soc: nxp: lpc55xxx: fix dependencies for SOC_FLASH_MCUX nxp-upstream/zephyr
1 participant
@danieldegrasse