Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: PAwR Sync does not compile without PAST receiver compiled in #76268

Closed
rugeGerritsen opened this issue Jul 24, 2024 · 0 comments · Fixed by #76269
Closed

Bluetooth: PAwR Sync does not compile without PAST receiver compiled in #76268

rugeGerritsen opened this issue Jul 24, 2024 · 0 comments · Fixed by #76269
Assignees
@jhedberg
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@rugeGerritsen
Copy link
Collaborator

Describe the bug
Building fails.
Enable CONFIG_BT_PER_ADV_SYNC_RSP but not CONFIG_BT_PER_ADV_SYNC_TRANSFER_RECEIVER.

To Reproduce
Build a sample application
Observe that linking fails because bt_hci_evt_le_past_received_v2 is not defined.

Impact
Increased flash usage

Environment (please complete the following information):
Using revision d6afb8f

Additional context
The issue was introduced in 711b42a
@rugeGerritsen rugeGerritsen added bug The issue is a bug, or the PR is fixing a bug area: Bluetooth labels Jul 24, 2024
rugeGerritsen added a commit to rugeGerritsen/zephyr that referenced this issue Jul 24, 2024
@rugeGerritsen
Bluetooth: Host: Fix compiling PAwR Sync without PAST RX
a95bbc3 
The function `bt_hci_le_past_received_v2()` is not compiled
in for this configuration, so the reference needs to be removed.

Fixes zephyrproject-rtos#76268.

Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
@rugeGerritsen rugeGerritsen mentioned this issue Jul 24, 2024
Merged
@rugeGerritsen rugeGerritsen added the priority: low Low impact/importance bug label Jul 24, 2024
@nashif nashif closed this as completed in e23345b Jul 27, 2024
zephyrbot pushed a commit that referenced this issue Jul 27, 2024
@rugeGerritsen @github-actions
Bluetooth: Host: Fix compiling PAwR Sync without PAST RX
8796a6f 
The function `bt_hci_le_past_received_v2()` is not compiled
in for this configuration, so the reference needs to be removed.

Fixes #76268.

Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
(cherry picked from commit e23345b)
ilhanates pushed a commit to ilhanates/zephyr that referenced this issue Aug 5, 2024
@rugeGerritsen @nordicjm
[nrf fromlist] Bluetooth: Host: Fix compiling PAwR Sync without PAST RX
ee94b90 
The function `bt_hci_le_past_received_v2()` is not compiled
in for this configuration, so the reference needs to be removed.

Fixes zephyrproject-rtos#76268.

Upstream PR: zephyrproject-rtos#76269

Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
@nashif nashif mentioned this issue Aug 6, 2024
Merged
nashif pushed a commit that referenced this issue Aug 6, 2024
@rugeGerritsen @nashif
Bluetooth: Host: Fix compiling PAwR Sync without PAST RX
a58e039 
The function `bt_hci_le_past_received_v2()` is not compiled
in for this configuration, so the reference needs to be removed.

Fixes #76268.

Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
(cherry picked from commit e23345b)
Chenhongren pushed a commit to Chenhongren/zephyr that referenced this issue Aug 26, 2024
@rugeGerritsen
Bluetooth: Host: Fix compiling PAwR Sync without PAST RX
047f5fb 
The function `bt_hci_le_past_received_v2()` is not compiled
in for this configuration, so the reference needs to be removed.

Fixes zephyrproject-rtos#76268.

(cherry picked from commit e23345b)

Original-Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
GitOrigin-RevId: e23345b
Change-Id: Iee19c2314258da38f5c4c47c94dbdcb47949b04c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5745020
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhedberg jhedberg

Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bluetooth: Host: Fix compiling PAwR Sync without PAST RX rugeGerritsen/zephyr
2 participants
@jhedberg @rugeGerritsen