Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#154 - Enable PHP 8.4 support #155

Merged
merged 2 commits into from
Nov 23, 2024
Merged

#154 - Enable PHP 8.4 support #155

merged 2 commits into from
Nov 23, 2024

Conversation

Jeckerson
Copy link
Member

Hello!

  • Type: new feature

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Thanks

@Jeckerson Jeckerson requested a review from niden November 23, 2024 10:05
@Jeckerson Jeckerson self-assigned this Nov 23, 2024
@Jeckerson Jeckerson linked an issue Nov 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (11e4afe) to head (bf4b6af).
Report is 3 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #155      +/-   ##
===============================================
+ Coverage        76.19%   76.70%   +0.51%     
===============================================
  Files                5        5              
  Lines             2962     3027      +65     
  Branches           128      128              
===============================================
+ Hits              2257     2322      +65     
  Misses             705      705              
Flag Coverage Δ
Linux 76.70% <ø> (+0.51%) ⬆️
unittests 76.70% <ø> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Jeckerson Jeckerson merged commit ac23688 into development Nov 23, 2024
87 of 120 checks passed
@Jeckerson Jeckerson deleted the #154-php84 branch November 23, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.4 support
2 participants