We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe there's a bug in the handling of trailing slashes, e.g. on https://cert-manager.io/docs/usage/gateway/#supported-annotations, there's a link:
[the annotations for Ingress resources](https://cert-manager.io/docs/usage/ingress#supported-annotations/)
The target link is incorrect; the trailing slash is appended after the #supported-annotations fragment but should be placed before it.
#supported-annotations
This is indicated by the following test, which fails currently (also attached, apply with git apply newtest.txt)
git apply newtest.txt
diff --git a/test/remark-plugins/links.test.js b/test/remark-plugins/links.test.js index 79f90c0..5bb82f6 100644 --- a/test/remark-plugins/links.test.js +++ b/test/remark-plugins/links.test.js @@ -128,7 +128,14 @@ const cases = [ prefix: 'v1.8-docs', slug: ['installation', 'helm'], expected: '/v1.8-docs/installation/compatibility' - } + }, + { + url: 'ingress.md#supported-annotation', + prefix: 'docs', + slug: ['usage', 'gateway'], + options: { trailingSlash: true }, + expected: '/docs/usage/ingress/#supported-annotation', + } ] test.each(cases)(
(attached: newtest.txt)
The text was updated successfully, but these errors were encountered:
fix: relative links with target and trailing slash, closes #6
f4fb801
No branches or pull requests
I believe there's a bug in the handling of trailing slashes, e.g. on https://cert-manager.io/docs/usage/gateway/#supported-annotations, there's a link:
The target link is incorrect; the trailing slash is appended after the
#supported-annotations
fragment but should be placed before it.This is indicated by the following test, which fails currently (also attached, apply with
git apply newtest.txt
)(attached: newtest.txt)
The text was updated successfully, but these errors were encountered: