Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native Node.js ES Modules support #74

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
.DS_Store
_*
node_modules
lib
dist/
lib/
node_modules/
2 changes: 0 additions & 2 deletions .npmignore

This file was deleted.

5 changes: 0 additions & 5 deletions esm.js

This file was deleted.

1 change: 0 additions & 1 deletion extras.js

This file was deleted.

1 change: 0 additions & 1 deletion index.js

This file was deleted.

85 changes: 85 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 18 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,32 @@
"description": "An Implementation of ES Observables",
"homepage": "https://github.com/zenparsing/zen-observable",
"license": "MIT",
"main": "./dist/cjs/index.js",
"exports": {
"require": "./dist/cjs/index.js",
"import": "./dist/es/index.js"
},
"module": "./dist/es/index.js",
"type": "commonjs",
"devDependencies": {
"@babel/cli": "^7.6.0",
"@babel/core": "^7.6.0",
"@babel/preset-env": "^7.6.0",
"@babel/register": "^7.6.0",
"@rollup/plugin-babel": "^5.0.0",
"eslint": "^6.5.0",
"mocha": "^6.2.0"
"mocha": "^6.2.0",
"rollup": "^2.14.0"
},
"dependencies": {},
"scripts": {
"test": "mocha --recursive --require ./scripts/mocha-require",
"build": "rollup --config",
"lint": "eslint src/*",
"build": "git clean -dfX ./lib && node ./scripts/build",
"prepublishOnly": "npm run lint && npm test && npm run build"
}
"prepare": "npm run build",
"prepublishOnly": "npm run lint && npm test",
"test": "mocha --recursive --require ./scripts/mocha-require"
},
"files": [
"dist/"
]
}
28 changes: 28 additions & 0 deletions rollup.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { babel } from '@rollup/plugin-babel';

function emitModulePackageFile() {
return {
name: 'emit-module-package-file',
generateBundle() {
this.emitFile({
type: 'asset',
fileName: 'package.json',
source: '{"type":"module"}',
});
},
};
}

export default {
input: ['src/index.js', 'src/extras.js'],
output: [
{ dir: 'dist/cjs/', format: 'cjs', exports: 'named' },
{ dir: 'dist/es/', format: 'es', plugins: [emitModulePackageFile()] },
],
plugins: [
babel({
babelHelpers: 'bundled',
plugins: require('./scripts/babel-plugins'),
}),
],
};
1 change: 0 additions & 1 deletion scripts/babel-plugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ module.exports = [
'@babel/plugin-transform-duplicate-keys',
'@babel/plugin-transform-for-of',
'@babel/plugin-transform-literals',
'@babel/plugin-transform-modules-commonjs',
'@babel/plugin-transform-parameters',
'@babel/plugin-transform-shorthand-properties',
'@babel/plugin-transform-spread',
Expand Down
7 changes: 0 additions & 7 deletions scripts/build.js

This file was deleted.

5 changes: 4 additions & 1 deletion scripts/mocha-require.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
require('@babel/register')({
plugins: require('./babel-plugins'),
plugins: [
...require('./babel-plugins'),
'@babel/plugin-transform-modules-commonjs',
],
});
2 changes: 1 addition & 1 deletion src/extras.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Observable } from './Observable.js';
import { Observable } from './index.js';

// Emits all values from all inputs in parallel
export function merge(...sources) {
Expand Down
2 changes: 2 additions & 0 deletions src/Observable.js → src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -474,3 +474,5 @@ if (hasSymbols()) {
configurable: true,
});
}

export default Observable;
2 changes: 1 addition & 1 deletion test/setup.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Observable } from '../src/Observable.js';
import { Observable } from '../src/index.js';

beforeEach(() => {
global.Observable = Observable;
Expand Down